Project-OMOTES / user_feedback

Repository to hold all feedback (bugs and feature request) from users
1 stars 0 forks source link

[Bug]: Not possible to set correct carries on connecting lines #35

Closed KelbijStarDeltares closed 3 months ago

KelbijStarDeltares commented 6 months ago

Is there an existing issue for this?

What happened?

Trying to connect all components in the mapeditor. Keep having issue with the carries on connection lines. For example I either have no carrier on a connection line or the wrong one.

Steps to reproduce the problem

  1. Load the ESDL
  2. Connect all components.
  3. Check with the validator.
  4. Another check: Save the esdl and reopen the esdl.

What should have happened?

Connection lines from the return pipe to assests should have the return carrier and the other way around for the supply pipe. test_simple storage_error.esdl.txt

What browsers do you use to access the UI?

None

Additional information

No response

FJanssen-TNO commented 6 months ago

If I understand correctly there is the cause and solution. However when I run the validator it does already give me error for not connecting ports properly or wrong assignment of carriers:

The Residualheatsource has its own ports connected to each other, its own inport connected to its own outport. This causes the same carrier being parsed through the entire network. This connection should be remove, the following steps can be taken: -click ResidualHeatSource_1

KelbijStarDeltares commented 6 months ago

Thank you Femke for checking. I will try it according to your steps. It seems to be caused while/after running the dual pipe service.

KelbijStarDeltares commented 6 months ago

Still the same issue: image image

KelbijStarDeltares commented 6 months ago

test_simple storage error 2.esdl.txt

FJanssen-TNO commented 6 months ago

A return temperature is required for the return carrier like this: image

I suppose we could give a more descriptive return error.

FJanssen-TNO commented 6 months ago

Here both above errors have been solved. test_simple with return network with return network.esdl.txt

KelbijStarDeltares commented 6 months ago

That was it! Indeed the error can be more descriptive, but also maybe a non-zero default value for the return carrier when using the dual pipe service or make the user fill in a value. Or other solutions that make it more clear for the user.