search

Project-OMOTES / user_feedback

Repository to hold all feedback (bugs and feature request) from users
1 stars 0 forks source link

[Bug]: GROW simualtor workflow cannot find carrier in ESDL #5

Closed samvanderzwan closed 4 months ago

samvanderzwan commented 1 year ago

Is there an existing issue for this?

What happened?

When starting a grow simulator calculation I got the following error: _get_supply_return_temperatures supply_temperature_id = asset.global_properties["carriers"][ KeyError: 'e96c4852-b2bc-43be-8fa7-5ae5e25a1883' While this key is in the ESDL.

ESDl is attached.

course_model with return network(11).esdl.txt

Steps to reproduce the problem

  1. Load ESDL into map editor
  2. Start simulator workflow
  3. Look at the results and log to see the error

What should have happened?

Either you get a proper error what is wrong or the simulation is performed

What browsers do you use to access the UI?

Mozilla Firefox

Additional information

No response

jimrojerTNO commented 12 months ago

@samvanderzwan Did you run the validator? The ESDL has a source directly connected to a node, this is not allowed. A source, demand, storage should always be connected to a pipe.

samvanderzwan commented 10 months ago

Noted, but is this checked by the validator? Maybe something to thing about if it is possible to drop this requirement. If it is needed for optimization purpose you might add a small pipe in code, so you could drop this requirement. But this is upto you to decide.

jimrojerTNO commented 10 months ago

It is checked by the validator. I want to keep this requirement as this pipe is also there in reality. In my opinion we can close this issue.