Sets linker flags for building libosrm.so shared library, resolves #172

Project-OSRM / node-osrm

DEPRECATED Part of osrm-backend since 5.7. NodeJS bindings for OSRM

BSD 2-Clause "Simplified" License

141 stars 48 forks source link

Sets linker flags for building libosrm.so shared library, resolves #172 #261

Closed daniel-j-h closed 7 years ago

daniel-j-h commented 7 years ago

For https://github.com/Project-OSRM/node-osrm/issues/172.

At the moment we only set linker flags for osrm-* binaries.

TheMarex commented 7 years ago

Failing because of: https://travis-ci.org/Project-OSRM/node-osrm/jobs/169404996#L1226

Apparently clang does not understand rt

springmeyer commented 7 years ago

Apparently clang does not understand rt

I wonder if this could be the bug I found and fixed in https://github.com/Project-OSRM/osrm-backend/pull/3130 whereby the libosrm.pc has -l rt instead of -lrt. @daniel-j-h you can pass --verbose to npm install to get the linking line to show up which should help diagnose.

codecov-io commented 7 years ago

Current coverage is 95.00% (diff: 100%)

Merging #261 into master will not change coverage

@@             master       #261   diff @@
==========================================
  Files             4          4          
  Lines           420        420          
  Methods          40         40          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            399        399          
  Misses           21         21          
  Partials          0          0

Powered by Codecov. Last update b8be777...f661aea

springmeyer commented 7 years ago

The problem @daniel-j-h ran into here was unrelated to this PR and was also impacting master. Found and fixing the bug (which I introduced) at https://github.com/Project-OSRM/osrm-backend/pull/3163.