Bundle osrm-unlock-all and other tools

Project-OSRM / node-osrm

DEPRECATED Part of osrm-backend since 5.7. NodeJS bindings for OSRM

BSD 2-Clause "Simplified" License

141 stars 48 forks source link

Closed daniel-j-h closed 7 years ago

daniel-j-h commented 7 years ago

We bundle the datastore but not its helper binary osrm-unlock-all. We should otherwise users are helpless when it comes to unlocking the shm locks.

cc @springmeyer

springmeyer commented 7 years ago

👍 to bundling all the tools that get built. We used to do this here but this changed in the move to node-cmake: https://github.com/Project-OSRM/node-osrm/commit/5667a3307e652dd2ec26bd6a743d71accbe53ec6#diff-af3b638bc2a3e6c650974192a53c7291R53. Perhaps we should move back to using a glob for all built tools?

TheMarex commented 7 years ago

This will be obsolete with 5.6 since #3528 adds the ability to remove shared locks.

oxidase commented 7 years ago

@TheMarex only osrm-unlock-all will be obsolete. Other tools are still ok

oxidase commented 7 years ago

Superseded by #3577, functionality was moved to osrm-datastore. -DBUILD_TOOLS enables only osrm-io-benchmark tool.