Project-OSRM / node-osrm

DEPRECATED Part of osrm-backend since 5.7. NodeJS bindings for OSRM
BSD 2-Clause "Simplified" License
141 stars 48 forks source link

Updates XCode 7.3 -> 8.2 on Travis #290

Closed daniel-j-h closed 7 years ago

daniel-j-h commented 7 years ago

Trying to see if it helps for https://github.com/Project-OSRM/node-osrm/issues/289.

daniel-j-h commented 7 years ago

https://travis-ci.org/Project-OSRM/node-osrm/jobs/194425064#L1149-L1151

The issue changed from the compiler error in the contractor assertion, to a Boost internal IPC assertion.

# route: routes Berlin using shared memory
[assert][0x7000175c7000] /Users/travis/build/Project-OSRM/node-osrm/mason_packages/headers/boost/1.61.0/include/boost/interprocess/sync/posix/condition.hpp:175
in: void boost::interprocess::ipcdetail::posix_condition::do_wait(boost::interprocess::ipcdetail::posix_mutex &): res == 0
ok 34 null
ok 35 should be truthy
# route: routes Berlin with geometry compression
libc++abi.dylib: terminating
make: *** [test] Abort trap: 6
make-test failed with 2
daniel-j-h commented 7 years ago

With the updated Boost 1.63

-- [Mason] Downloading package https://mason-binaries.s3.amazonaws.com/osx-x86_64/boost_libsystem/1.63.0.tar.gz...

still seeing the assertion in Boost.Interprocess

[assert][0x70001610a000] /Users/travis/build/Project-OSRM/node-osrm/mason_packages/headers/boost/1.63.0/include/boost/interprocess/sync/posix/condition.hpp:175
in: void boost::interprocess::ipcdetail::posix_condition::do_wait(boost::interprocess::ipcdetail::posix_mutex &): res == 0
libc++abi.dylib: terminating

I skimmed the Boost.Interprocess repo. but couldn’t find anything obvious from a quick skim.

danpat commented 7 years ago

@oxidase has found the root cause of this assertion here: https://github.com/Project-OSRM/osrm-backend/pull/3627

It's not XCode 7.3/8.0 specific, but an OSX bug. I'm 👍 on just updating to XCode 8.x anyway.

@daniel-j-h Good to merge this change, the real problem needs to be fixed in osrm-backend and the test suite.

daniel-j-h commented 7 years ago

Okay :+1: