Clean Up Unused Travel Modes

Project-OSRM / osrm-backend

Open Source Routing Machine - C++ backend

http://map.project-osrm.org

BSD 2-Clause "Simplified" License

6.3k stars 3.33k forks source link

Clean Up Unused Travel Modes #2879

Open daniel-j-h opened 8 years ago

daniel-j-h commented 8 years ago

Looking over supported travel modes in https://github.com/Project-OSRM/osrm-backend/pull/2877 I came across unused travel modes:

https://github.com/Project-OSRM/osrm-backend/blob/b2858350a9e9022b5ce9fee8a92b5a845ab4a3a7/include/extractor/travel_mode.hpp#L49-L54

Let's rip them out for good:

[ ] remove from travel mode
[ ] remove in scripting env
[ ] remove from json travel mode translation
[ ] adapt testbot profile
[ ] rip out testbot cucumber tests

MoKob commented 8 years ago

The problem here is that if we remove these travel modes, we would also change the API. An assignment, even though not used so far, of these modes would not be possible anymore.

Like so many small changes, we should target their removal for 6.0.