Open chaupow opened 6 years ago
Possible first steps
turn-lane-handler
here https://github.com/Project-OSRM/osrm-backend/blob/master/src/guidance/turn_analysis.cpp#L40@oxidase @chaupow does this mean that turn-lane data would be the primary source for turn identification where it is present? That seems fairly brittle and prone to mistagging or vandalism. On the other hand, the idea is a good one -- turn lanes are good input into the turn type. Can we limit this somehow so the turn lanes function as an input rather than the primary classifier?
does this mean that turn-lane data would be the primary source for turn identification where it is present? That seems fairly brittle and prone to mistagging or vandalism.
Turn lane tags aren’t any more fragile than name
, destination
, ref
, or highway
tags. Those tags affect guidance in more profound ways, and they’re far more open-ended than turn lane tags.
Can we limit this somehow so the turn lanes function as an input rather than the primary classifier?
OSRM already discards turn lane indications it thinks are nonsensical. In fact, there are plenty of examples (see below) where OSRM is too aggressive in discarding turn lane indications. When OSRM encounters a counterintuitive cardinal direction or maneuver relation, it honors it. I don’t see why turn lane tags should be any different, given that these tags are almost always based on verifiable imagery or groundtruthing.
Related to #3365 and missing instruction at http://map.project-osrm.org/?z=18¢er=49.487491%2C8.476472&loc=49.487747%2C8.477073&loc=49.487218%2C8.475899&hl=en&alt=0
This issue seems to be stale. It will be closed in 30 days if no further activity occurs.
Currently OSRM generates instructions such as
right
orleft
by identifying left or right turns based on the geometry.Interpreting geometries correctly is difficult and often we do not interpret it correctly. Example: This should turn left
Fixing guidance and geometry identification is a bigger lift, what we this issue proposes is to use turn lanes information to annotate turn types as a "fallback" or "quick fix":
If, for example, there are turn lanes saying
left|right
at an intersection, we should annotate the turns asleft
andright
accordingly and not annotate themstraight
andright
even if we might conclude that with the geometry.Unfortunately, the OSM database does not have a lot of turn lanes, so we definitely cannot base our guidance solely on turn lanes and disregard geometry identification. There are still reasons why we would want this fix: