search

Project-OSRM / osrm-backend

Open Source Routing Machine - C++ backend
http://map.project-osrm.org
BSD 2-Clause "Simplified" License
6.29k stars 3.32k forks source link

MAX_COLLAPSE_DISTANCE and precise pedestrian steps #6171

Open kaligrafy opened 2 years ago

kaligrafy commented 2 years ago

We are trying to route pedestrian with precise steps, including the road crossings which we mapped for every intersection on a small region. Our government partners and transit operators in the region want to be able to get precise routing for pedestrian to assess route security (probability of accidents). However, since MAX_COLLAPSE_DISTANCE is set to 30, any mapped crossing (footway=crossing) shorter than 30 m is merged and ignored in the steps, so that makes our analysis impossible since we don't know the total distance for which the pedestrian is crossing the road vs the distance the pedestrian is on a sidewalk or on a designated footpath.

Would it be possible to add MAX_COLLAPSE_DISTANCE to the main routing parameters or in the lua profile so we do not need to fork and maintain a branch just for this? Thanks!

danpat commented 2 years ago

Would it be possible to add MAX_COLLAPSE_DISTANCE to the main routing parameters or in the lua profile so we do not need to fork and maintain a branch just for this? Thanks!

Seems reasonable - want to submit a PR that implements that?

kaligrafy commented 2 years ago

Is it possible to add it to the lua profile? Is a parameter for this in the lua profile would be available during the processing stage?

danpat commented 2 years ago

Take a look at the max_speed_for_map_matching and continue_straight_at_waypoint properties that are set in car.lua - these don't get used by processing, but they are saved into the routing files so that they can be used at query time - that's what you'd want for this parameter.

kaligrafy commented 2 years ago

OK, thanks!

github-actions[bot] commented 2 months ago

This issue seems to be stale. It will be closed in 30 days if no further activity occurs.

kaligrafy commented 2 months ago

We will propose a PR soon for this, please keep open.