Project-OSRM / osrm-backend

Open Source Routing Machine - C++ backend
http://map.project-osrm.org
BSD 2-Clause "Simplified" License
6.21k stars 3.29k forks source link

Blacklist access=permit for cars #6295

Open ftrebien opened 1 year ago

ftrebien commented 1 year ago

The access=permit tag (and vehicle=permit, _motorvehicle=permit, etc.) has been widely adopted since the second half of 2018. For routing, it has implications similar to access=private as generally only locals have these permits, so I I think it should also be on the default access blacklist. It usually occurs in congested city centers and often in areas with electronic surveillance where unauthorized traffic automatically results in a (usually hefty) fine.

SiarheiFedartsou commented 1 year ago

Not sure we should do it by default(probably we should, but for some use cases it is questionable), but you can do it on your own just by adding this tag here https://github.com/Project-OSRM/osrm-backend/blob/e7185b4bcb7eb17ea4f85dc3d087880dbd309646/profiles/car.lua#L77

flohoff commented 1 year ago

Just to come back to this issue.

Permit ist not different to "private" - So we should deal with it the same.

So yes - please add "permit" to the access tag blacklist.

We as an application dont know if the user has a permit for every snippet of road out there tagged with "access=permit" so our assumption must be the user does not have one.

Flo

flohoff commented 6 months ago

I just made this patch for the car profile - It also disallows snap-to service roads with permit.

https://github.com/Project-OSRM/osrm-backend/commit/1fcea94e6f4c944d5c6976495b82eced0f063189

github-actions[bot] commented 2 weeks ago

This issue seems to be stale. It will be closed in 30 days if no further activity occurs.

flohoff commented 2 weeks ago

Further activity as its still not merged.

DennisOSRM commented 2 weeks ago

Further activity as its still not merged.

What's the related PR?