Open freenerd opened 7 years ago
The grammar feature added in #102 can be used to decline tokens for gender. Alternatively, we could avoid spelling out the ordinal numbers, translating “first” as “1.” I suspect most text-to-speech engines would be able to handle that representation correctly. Would it be OK to write it that way for display on screen?
/cc @daniel-j-h @yuryleb
As I could see, {nth}
is used only in arrive
block, why don't correct ordinalize
constants right on Transifex with changing erste
to erstes
and so on? Russian translation also has these constants adopted to gender used in arrive
instructions.
Oh, sorry, currently these ordinalize
contants are used as {exit_number}
in roundabout
instructions :disappointed: And they are adopted to Ausfahrt
feminine gender. Actually I couldn't find appropriate synonym for the Ziel
of the same gender.
So it's really possible to extend grammar with masculine
, feminine
, neuter
options - for example {exit_number:feminine}
and {nth:neuter}
. I could prototype code/JSON for this but some German should check after me then.
Usually you expand numbers up to twelve as words and only then you write them out as numbers.
In the context of an app with limit screen space I think it's totally fine to use numbers when the TTS engines can handle it anyway.
Ok, no action from me yet :wink:
But actually I supposed our instructions should be used by TTS primarily and be on screen for debug purposes only :wink: App should display just arrow icon(s), distance and way name/destination for the next maneuver, shouldn't it?
This library is also used for Web interfaces such as the OSRM demo site that display the steps in a list of sentences. Navigation applications often have a similar step table; the iOS navigation SDK uses the Swift port of this library to generate the step table.
As per https://github.com/Project-OSRM/osrm-text-instructions/pull/111/files?diff=split#r121345638 we need to fix the german translation of counting multiple waypoints:
Now:
Sie haben Ihr erste Ziel erreicht
.Correct:
Sie haben Ihr erstes Ziel erreicht
.Options: