Project-OSRM / osrm-text-instructions

Text instructions from OSRM route responses
BSD 2-Clause "Simplified" License
90 stars 63 forks source link

Remove traffic circle names from the roundabout and rotary instructions #173

Closed mcwhittemore closed 7 years ago

mcwhittemore commented 7 years ago

This is superfluous information most of the time as roundabouts and rotaries are visually obvious things. We should simply sat at the traffic circle, take the 1st exit rather than At {name}, take the 1st exit`

daniel-j-h commented 7 years ago

What's the use-case for not passing through information from the backend here?

At least in Germany there are lots of rotaries you really want to announce by their names e.g.

whic are well-known and even tram and underground stations there are called by the rotary's name.

MoKob commented 7 years ago

I would also like to add, that the places not necessarily are visually obvious: Two examples here. One of which is currently tagged with junction=roundabout, the other isn't. It isn't necessarily highly obvious, that this is a traffic circle. Names, as @daniel-j-h already mentioned can be far more obvious, based on train stations and similar.

screen shot 2017-10-12 at 09 52 46 screen shot 2017-10-12 at 09 54 16
mcwhittemore commented 7 years ago

So, talking this over with @MoKob a bit offline, I think I can force the step to use roundabout.exit.default when using OSRM Text Instructions to make mp3s.

mcwhittemore commented 7 years ago

This has been done for english, if other languages want to follow suite, they can via transifex.