search

Project-OSRM / osrm-text-instructions

Text instructions from OSRM route responses
BSD 2-Clause "Simplified" License
88 stars 62 forks source link

Extend Russian grammar tests #192

Closed yuryleb closed 6 years ago

yuryleb commented 6 years ago

This PR adds test names for all status street names in Russian grammar rules and fixes some detected errors in grammar expressions.

yuryleb commented 6 years ago

Actually adding tests is infinite work but maybe somebody could review & merge this PR with made changes? All further efforts could be added with newer PRs (I have some plans to check all Russian street names collated by Russian street names validator but in some far away future)? @1ec5, what do you think, should I update change log with these quite minor fixes (especially for other languages) or not?

1ec5 commented 6 years ago

All further efforts could be added with newer PRs (I have some plans to check all Russian street names collated by [Russian street names validator](https://github.com/AMDmi3

@yuryleb, would you mind opening separate issues describing what you’re thinking of doing in this space? We might be able to get others to help with test cases as well. Thanks!