search

Project-OSRM / osrm-text-instructions

Text instructions from OSRM route responses
BSD 2-Clause "Simplified" License
87 stars 61 forks source link

Added European Portuguese localization #229

Closed 1ec5 closed 6 years ago

1ec5 commented 6 years ago

Issue

Added a European Portuguese localization from Transifex. Also updated the Brazilian Portuguese localization, which still has some gaps in translation.

@Rui-Santos, thanks for the translations! Please take a look at the test fixtures to ensure the generated sentences make sense. Feel free to keep refining the translations; we can update this PR in parallel until you think it’s ready for an initial release.

Tasklist

Requirements / Relations

This supersedes the Portuguese portion of #200. It complements the UI localizations added in mapbox/mapbox-navigation-ios#1252.

/cc @lyzidiamond @danpaz

1ec5 commented 6 years ago

Also, it would be good to add an abbreviation file for Portuguese at some point, but that can happen in a separate PR.

Rui-Santos commented 6 years ago

Look fine to me. I guess any unnatural language quirks will only be noticed with it being used without the placeholders. I'll see if tomorrow I can put a couple hours aside and take care of the abbreviatons.

1ec5 commented 6 years ago

Sounds good. Feel free to open a PR or issue if you spot any problems or need any strings updated here.

Rui-Santos commented 6 years ago

OK, I need more than a couple hours for the abbreviations. Need to parse a list with thousands of them and get only the ones that are used in toponymics. Take will take more time than I was expecting. It will take a few days. Will have to go through the list letter by letter, one at a time, when I get some free time, or when I get tired of translating and need something else to do.

1ec5 commented 6 years ago

No worries, it’s totally fine to start out with just the most common abbreviations, things like “Pq” for “parque”. There are plenty of abbreviations in English that we omit because we’re not sure a user would comprehend it correctly at a glance, and also plenty that we omit because they’re only applicable to a particular region.