search

Project-OSRM / osrm-text-instructions

Text instructions from OSRM route responses
BSD 2-Clause "Simplified" License
90 stars 63 forks source link

Add Finnish translations #239

Closed akikoskinen closed 6 years ago

akikoskinen commented 6 years ago

Proposing Finnish translations. I continued the translations mentioned in issue #223.

This commit has issues, not all the translations are very fluent. Consider this version for review, but there's definitely room for improvement. I also post this here so that it gets visibility and perhaps some people can help in improving this.

This is the best I can do with just Transifex, but some of these aren't very good Finnish. For example the modifier left is translated as vasemmall(e/a). That's because the modifier is used in different contexts and a different form of the word would be needed. Roughly: "to the left" is "vasemmalle", "on the left" is "vasemmalla".

This and other issues can maybe be solved with the grammar system, but I haven't yet studied how that works.

yuryleb commented 6 years ago

Currently grammar works with way_name and rotary_name values only but why not to extend it somehow to process whole phrase or a new keyword? Anyway this could be done in a new pull request but this one should be finished with ChangeLog update :wink:

akikoskinen commented 6 years ago

I would say either way is good. The current Finnish in this PR isn't fluent at all places but it's understandable. So I guess it's better than nothing.

Maybe it boils down to the quality ambitions of this project and the release schedule. If the quality ambition is very high and a release is approaching, then I wouldn't include this PR yet. If the approach is more that any value added is good (and can be improved later) or no release is right behind the corner, then I would say that this can go now as it is and once #240 is in, then Finnish (and other) strings can be improved.

So I think I'm throwing the ball right back at ya :smile: