search

Project-OSRM / osrm-text-instructions

Text instructions from OSRM route responses
BSD 2-Clause "Simplified" License
90 stars 63 forks source link

Finnish translation has vasemmall(e/a) instead of using either vasemalle or vasemmalla correctly #260

Open mkv123 opened 6 years ago

mkv123 commented 6 years ago

In Finnish there is a difference for the word "left" if you intend to keep to the left side or something is on the left side (vasemmalla) or if you are turning leftwards (vasemmalle). Same goes for "right". In the current translation, rather than differentiating between these two cases, the slightly cryptic looking vasemmall(e/a) is used.

It appears this is mainly because the English translation is using the default case with {modifier} token and the Finnish translation has done the same.

I have a fix for this where I've used "vasemmalle" for "left" and in the few cases where "vasemmalla" is correct and {modifier} is used in the "default" case, I've added the special cases for "left" and "right" with "vasemmalla".

I'm not familiar with transifex, so I'm not sure if just editing the translation files and updating the tests is the correct way to do this.

mkv123 commented 6 years ago

Oh, just found the quite detailed CONTRIBUTING.md, I'll see if I can figure out the transifex and override stuff.

mkv123 commented 6 years ago

Looking at the original PR #239 already mentions this problem, and the solution I came up with is being tracked at #240.

Just FYI, by setting "vasemmalle" as the default case for "left", I think only "fork" needes the special "left" and "right" cases in Finnish.

I'll leave this open, as once #240 is resolved, the Finnish translations need to be updated.