Add Hungarian localization

[yuryleb]

Issue

Initial Hungarian translation contributed by @kiskunk initally discussed in #271. Thanks a lot!

Tasklist

• [x] Review
• [x] Add changelog entry
• [x] Test with osrm-frontend (?)

[yuryleb]

No problem, that's the review goal is 😉

[alexwyattdev]

No problem, that's the review goal is 😉

Ok, will I get a new notification if the new review is available, or I have to check back regularly? Thanks.

[yuryleb]

I'll add comment here and then you'll get a notification. Did you already update translation on Transifex?

[alexwyattdev]

I'll add comment here and then you'll get a notification. Did you already update translation on Transifex?

Yes, I did it before commenting on the review here.

[yuryleb]

IMHO missing whitespace after {modifier} in new name stuff:

        "merge": {
            "default": {
                "default": "Soroljon be {modifier}",
                "name": "Soroljon be {modifier}a(z) {way_name} felé",
                "destination": "Soroljon be {modifier} ehhez: {destination}"
            },

[alexwyattdev]

IMHO missing whitespace after {modifier} in new name stuff:

        "merge": {
            "default": {
                "default": "Soroljon be {modifier}",
                "name": "Soroljon be {modifier}a(z) {way_name} felé",
                "destination": "Soroljon be {modifier} ehhez: {destination}"
            },

Fixed it, tho it's really hard to keep track since almost every value exist 6 times.

[yuryleb]

Actually no, only destination was changed but name still need for whitespace:

        "merge": {
            "default": {
                "default": "Soroljon be {modifier}",
                "name": "Soroljon be {modifier}a(z) {way_name} felé",
                "destination": "Soroljon be {modifier} a(z) {destination} irányába"
            },

And there are several similar cases, I recommend to use Transifex search for translated strings with }a pattern.

[alexwyattdev]

I only saw one, fixed, then searched for }a and found nothing. Is it possible to remove the ultimate redundancy somehow so every string would be there only 1 times?

[yuryleb]

I pushed your updated translation, please review result again.

IMHO there are extra whitespaces in name and ref now :wink:

        "phrase": {
            "two linked by distance": "{instruction_one} , majd {distance} múlva, {instruction_two}",
            "two linked": "{instruction_one} , majd {instruction_two}",
            "one in distance": "{distance} múlva {instruction_one}",
            "name and ref": "{name} ( {ref} )",
            "exit with number": "{exit} kijárat"
        },

[alexwyattdev]

Sorry, i wanted to make sure there is always whitespace, tomorrow I will check them, so to be clear there can be braces and commas after them ?

[yuryleb]

I suppose there should be just "name and ref": "{name} ({ref})",

[yuryleb]

Next commit pushed. But now there are extra whitespaces 😞

[alexwyattdev]

Transifex really plays out its cards... oh well, tried to fix them all.

[yuryleb]

Committed last fix. Translation looks good for me now 👍

BTW maybe you could also add translation to the frontend? It's necessary just add new hu.js into i18n folder with similar content:

module.exports = {
  name: 'English',
  key: 'en',
  'Open in Debug Map': 'Open in Debug Map',
  'Open in Mapillary': 'Open in Mapillary',
  'GPX': 'Export GPX file',
  'Open in editor': 'Open in editor',
  'Open in JOSM': 'Open in JOSM',
  'Select language': 'Select language',
  'Start - press enter to drop marker': 'Start - press enter to drop marker',
  'End - press enter to drop marker': 'End - press enter to drop marker',
  'Via point - press enter to drop marker': 'Via point - press enter to drop marker'
};

and register it in src/localization.js?

You could do this in your own new pull request or just send/type translation for me. Then I could test your localization for osrm-text-instructions together with frontend.

[yuryleb]

Translation is also checked with frontend:

So if all is ok, maybe this could be merged?

Also IMHO new version of whole package should be released already, maybe maintainers could do this finally?

/cc @1ec5

[alexwyattdev]

Translation is also checked with frontend:

So if all is ok, maybe this could be merged?

Also IMHO new version of whole package should be released already, maybe maintainers could do this finally?

/cc @1ec5

It looks and reads correct.

[yuryleb]

Maybe @danpaz could merge this PR?

[alexwyattdev]

Also I already had to write my own logic for correcting a(z) including highway names, since my project needed to proceed further. (Its on android, not js and not regex based)

[1ec5]

Its on android, not js and not regex based

If you’re using the Mapbox Navigation SDK for Android, note that improvements to OSRM Text Instructions are incorporated into the Mapbox Directions API and therefore the navigation SDK as well. Ideally the navigation SDK would take care of details like this so you don’t have to in your application code.

[alexwyattdev]

An example of special case dor a az: usually highways in hungary starts with an M and then a number and the pronounciation is "emm" so thats why it needs an az before it in this special case.

[yuryleb]

usually highways in hungary starts with an M and then a number and the pronounciation is "emm"

Makes sense 😉

@kiskunk, could you please also answer for my questions above? And also should Hungarian street names be changed together with status names for a grammatical case similar to Russian streets?

[alexwyattdev]

usually highways in hungary starts with an M and then a number and the pronounciation is "emm"

Makes sense 😉

@kiskunk, could you please also answer for my questions above? And also should Hungarian street names be changed together with status names for a grammatical case similar to Russian streets?

So here is a complete list of possible street ending names (i mean like in Boulevard Street where "Street" is the ending) it includes those 11 too from your link.

WayNameEnding[] wayNameEndings = { new WayNameEnding(" árok", "árkon", "árokra"), new WayNameEnding(" átjáró", "átjárón", "átjáróra"), new WayNameEnding(" dűlő", "dűlőn", "dűlőre"), new WayNameEnding(" dűlőút", "dűlőúton", "dűlőútra"), new WayNameEnding(" erdősor", "erdősoron", "erdősorra"), new WayNameEnding(" fasor", "fasoron", "fasorra"), new WayNameEnding(" forduló", "fordulón", "fordulóra"), new WayNameEnding(" gát", "gáton", "gátra"), new WayNameEnding(" határsor", "határsoron", "határsorra"), new WayNameEnding(" határút", "határúton", "határútra"), new WayNameEnding(" kapu", "kapun", "kapura"), new WayNameEnding(" körönd", "köröndön", "köröndre"), new WayNameEnding(" körtér", "körtéren", "körtérre"), new WayNameEnding(" körút", "körúton", "körútra"), new WayNameEnding(" köz", "közön", "közre"), new WayNameEnding(" lakótelep", "lakótelepen", "lakótelepre"), new WayNameEnding(" lejáró", "lejárón", "lejáróra"), new WayNameEnding(" lejtő", "lejtőn", "lejtőre"), new WayNameEnding(" lépcső", "lépcsőn", "lépcsőre"), new WayNameEnding(" liget", "ligeten", "ligetre"), new WayNameEnding(" mélyút", "mélyúton", "mélyútra"), new WayNameEnding(" orom", "ormon", "oromra"), new WayNameEnding(" ösvény", "ösvényen", "ösvényre"), new WayNameEnding(" park", "parkon", "parkra"), new WayNameEnding(" part", "parton", "partra"), new WayNameEnding(" pincesor", "pincesoron", "pincesorra"), new WayNameEnding(" rakpart", "rakparton", "rakpartra"), new WayNameEnding(" sétány", "sétányon", "sétányra"), new WayNameEnding(" sikátor", "sikátoron", "sikátorra"), new WayNameEnding(" sor", "soron", "sorra"), new WayNameEnding(" sugárút", "sugárúton", "sugárútra"), new WayNameEnding(" tér", "téren", "térre"), new WayNameEnding(" udvar", "udvaron", "udvarra"), new WayNameEnding(" út", "úton", "útra"), new WayNameEnding(" utca", "utcán", "utcára"), new WayNameEnding(" üdülőpart", "üdülőparton", "üdülőpartra"), new WayNameEnding(" lánchíd", "lánchídon", "lánchídra"), new WayNameEnding(" híd", "hídon", "hídra")};

Grammatical cases as far as i could determine it would require only 2 of ours, but i do not know the name of those cases. the first is the root name, the second is how it changes when you would say "on Boulevard Street", the 3rd is how it would change when you would say "onto Boulevard Street" its a much harder implementation (if even possible) because its based on vowel harmony for 90%, so its not even for 100%... what i put in the translation on transifex solves this issue by using an additional word like if you would say "turn left onto Boulevard Street section"

I think with using the grammar file for standard street names to balance out a/az AND making a rule for M0, M1 ... M85 ... etc would cover almost all except the non-hungarian street names (there are only a few)

For the grammatical cases and the M0..M1 highway names its another dimension of difficulty (at least when the Mapbox SDK tries to read it out loud), because of how it would say the numbers, the numbers also would require a different suffix. For example M0 would be read like "emm nulla" but since we want to use it in context and a sentence, it would be "emm nullás", and thats not the end because it would still need the "section" word after it (which i think its already there in transifex because its a general translation) or to be better for the ears, the logic from the previous grammar cases, making it into "emm nulláson" or "emm nullásra", to write this logic it requires to have the numbers 0-20,30,40,50,60,70,80,90,100,200,300.. etc to be defined too with that 2 grammar case, maybe its enough to stay below 1000, i don't think that would come up in any hungarian highway names.

[1ec5]

For example M0 would be read like "emm nulla" but since we want to use it in context and a sentence, it would be "emm nullás", and thats not the end because it would still need the "section" word after it (which i think its already there in transifex because its a general translation) or to be better for the ears, the logic from the previous grammar cases, making it into "emm nulláson" or "emm nullásra", to write this logic it requires to have the numbers 0-20,30,40,50,60,70,80,90,100,200,300.. etc to be defined too with that 2 grammar case, maybe its enough to stay below 1000, i don't think that would come up in any hungarian highway names.

An SSML-aware text-to-speech engine might already handle optimizing numbers or alphanumeric words for speech. (The Mapbox Directions API wraps {way_name} etc. in <speak-as interpret-as="address"> for that reason.) I don’t think OSRM Text Instructions is in a great position to implement number formatting for speech all by itself. That would be a valid feature request against the navigation SDK for when it falls back to the Android TTS engine (since the Mapbox Voice API doesn’t support Hungarian).

what i put in the translation on transifex solves this issue by using an additional word like if you would say "turn left onto Boulevard Street section"

That’s reasonable. The only reason I brought up the grammar file was because of “a(z)”, which a text-to-speech engine is unlikely to pronounce correctly under any circumstance, unfortunately. That said, this PR doesn’t have to be the end of Hungarian localization work. If you think optimizing articles and numbers would be enough of a rabbit hole, we can merge this PR and would welcome any additional contributions regarding grammar.

[yuryleb]

If we're talking about articles change only, it's not too hard to implement here 😉

BTW how a/az should be changed before numbers in phrases like "Megérkezett a(z) 1. célponthoz, a bal oldalon" - I suppose to a everywhere?

But adding 2 grammatical cases support will be not too hard too if we need to change street status name only. @kiskunk, am I understand properly that "turn right onto the street" instruction with Dohány utca street name should look like:

Forduljon be jobbra a Dohány utcára felé

And we don't need to change the Dohány name?

[alexwyattdev]

I think a(z) is ok for now. As for jumbers it would be "megérkezett az 1. célponthoz" but "megérkezett a 2. célponthoz" so its atain an another level of complication of what letter the spoken number would start with.

And for the street name it would be: Forduljon jobbra a Dohány utcára. without the "felé" and yes Dohány would not change

[yuryleb]

Ok, please look at first Hungarian grammar rules to handle articles only yet:

Grammar could be extended further to apply grammatical cases to Hungarian street names - I suppose this could be based on analyzing of following magic words after {way_name} & {rotary_name} variables:

• felé
• irányába
• szakaszon

@kiskunk, you told about 2 grammatical cases but here are 3 variants - does some of them use the same grammatical case as another (if I'm right in my presumption at all)?

And BTW you seem to forget to include alagút (tunnel) status name into your wayNameEndings list.

[alexwyattdev]

The image looks correct.

My list was from Wikipedia, so i will have to try to update that too with alagút. thanks.

Felé and Irányába are interchange-able, they both represent one of the 2 cases, szakaszon represents the other. I just added the other 2 for a little bit of word diversity, I used felé for way_names, and irányába for destination.

[yuryleb]

One more question, @kiskunk: how to proceed foreign names - I suppose it's better to keep these felé/irányába/szakaszon words on their original place in instructions?

[alexwyattdev]

yes, thats the best way i can imagine

[alexwyattdev]

Yes, I corrected the irányába, and added the missing a(z)

[yuryleb]

OK, now I added support of Sublative and Superessive grammatical cases (yes, they're called so :wink:), please review how this looks on Hungarian streets: And on foreign ones:

[alexwyattdev]

Looks good to me, great job, thanks.