search

Project-OSRM / osrm-text-instructions

Text instructions from OSRM route responses
BSD 2-Clause "Simplified" License
86 stars 60 forks source link

Extra `à` in french waypoint_name arrival instruction #275

Closed danpaz closed 5 years ago

danpaz commented 5 years ago

I noticed a typo in the french localization of the arrive.right.named maneuver instruction:

https://github.com/Project-OSRM/osrm-text-instructions/blob/9de8ca2e5c9a6071b704bd302fca9a293de73365/languages/translations/fr.json#L80

There appears to be an extra à and whitespace. These should be removed, and the fixtures should be regenerated.

yuryleb commented 5 years ago

Is it in Transifex translation?

1ec5 commented 5 years ago

The JSON translation file reflects what’s in Transifex, yes. The extra “à” is added by this grammar rule:

https://github.com/Project-OSRM/osrm-text-instructions/blob/9de8ca2e5c9a6071b704bd302fca9a293de73365/languages/grammar/fr.json#L184

So should the grammar rule or the translation be responsible for adding “à”?