search

Project-OSRM / osrm-text-instructions

Text instructions from OSRM route responses
BSD 2-Clause "Simplified" License
86 stars 60 forks source link

Add Yoruba localization #284

Closed 1ec5 closed 5 years ago

1ec5 commented 5 years ago

Thanks to @toblinkz for contributing a complete Yoruba localization in Transifex!

@toblinkz, can you double-check that the generated sentences make sense? Thanks!

/ref mapbox/mapbox-navigation-android#2000 /cc @danpaz @Guardiola31337

toblinkz commented 5 years ago

Good afternoon, please how can I can a make a third Party TTS engine in my application that would be responsible for yoruba pronounciation?

On Fri, Jul 19, 2019 at 6:25 PM Minh Nguyễn notifications@github.com wrote:

@1ec5 commented on this pull request.

There are a number of messages that seem to lack spaces around tokens, which would be problematic for any text-to-speech engine.

In test/fixtures/v5/continue/left_destination.json https://github.com/Project-OSRM/osrm-text-instructions/pull/284#discussion_r305451609 :

@@ -37,6 +37,7 @@

     "tr": "Destination 1 istikametinde sol yöne dön",

     "uk": "Поверніть ліворуч у напрямку Destination 1",

     "vi": "Quẹo trái về Destination 1",
  • "yo": "Tan-anapa osisi ọnaDestination 1",

Should the destination name be tacked onto the end of “ọna” like this, or should there be a space in between?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Project-OSRM/osrm-text-instructions/pull/284?email_source=notifications&email_token=AD5JSRN43XNL4DNV7XEJLG3QAH2HFA5CNFSM4IFI4QY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7AXJCA#pullrequestreview-264336520, or mute the thread https://github.com/notifications/unsubscribe-auth/AD5JSRPAZNVZ7ZPNQF67GYDQAH2HFANCNFSM4IFI4QYQ .

1ec5 commented 5 years ago

Good afternoon, please how can I can a make a third Party TTS engine in my application that would be responsible for yoruba pronounciation?

I assume you’re referring to using a third-party TTS engine with the Mapbox Navigation SDK, per https://github.com/mapbox/mapbox-navigation-android/issues/2000#issuecomment-513310745. Here’s a contrived example for iOS. The key is to subclass MapboxVoiceController and override speak(_:) to invoke the third-party TTS engine. If you need a corresponding hook for Android, I’d suggest following up in the mapbox-navigation-android repository.