search

Project-OSRM / osrm-text-instructions

Text instructions from OSRM route responses
BSD 2-Clause "Simplified" License
86 stars 60 forks source link

Updated Danish translations #286

Closed cmahopper closed 4 years ago

cmahopper commented 4 years ago

Closes #258. @1ec5

Updated Danish translations and fixed some abbreviations.

yuryleb commented 4 years ago

And translations should be updated on https://www.transifex.com/project-osrm/osrm-text-instructions/language/da/ first not directly in languages/translations/da.json file

cmahopper commented 4 years ago

@yuryleb I see. The problem with translating on Transifex is that I cannot add modifiers as separate strings. See this for example: https://github.com/Project-OSRM/osrm-text-instructions/pull/286/files#diff-2c8beca969ab6776d6f6d01bc61ea58aR208-R211

I cannot use the default modifier. It may work in English, but it doesn't work in Danish. The same goes for sharp/slight left/right. It's just not possible in Danish.

What would you suggest instead?

cmahopper commented 4 years ago

@yuryleb I've updated the Transifex translations to the best of my ability, but the issues above are still present.

yuryleb commented 4 years ago

Thank you. Could you please now update files again but from Transifex (and don't forget ChangeLog 😉) and point me some fixture files with these incorrect sharp/slight left/right strings and comment what should be there instead - this allows me to understand the issue more completely. IMHO this could be fixed with post-processing by new grammar rules for Danish but I need more info yet.

yuryleb commented 4 years ago

So let's try to reduce total number of incorrect phrases in fixures with Transifex first:

cmahopper commented 4 years ago

@yuryleb I've updated Transifex and pushed the changes, I'm gonna go through the tests now and note any incorrect translations.

yuryleb commented 4 years ago

@cmahopper, actually I already prepared a commit to push initial grammar rules right into your branch here but has no permissions to do this 😞 Maybe you could try to give me write access while we're waiting @1ec5 for approval?

cmahopper commented 4 years ago

@yuryleb You should be added as a collaborator now :)

yuryleb commented 4 years ago

Thanks! Please review proposed grammar rules and resulting fixtures. I didn't add special grammar tests so as all results are controlled with them.

cmahopper commented 4 years ago

@yuryleb The test results look perfect!

There's a final thing that still results in a weird speak, but I'm not sure if it can be fixed in the same way. I wrote it in this comment: https://github.com/Project-OSRM/osrm-text-instructions/pull/286#discussion_r317909524

The arrival string that starts with "Du vil ..." should be the only case where the first two words need to be switched. Would you be able to take a look at it?

yuryleb commented 4 years ago

Currently I has no idea how to fix this - current grammar rules implementation may not help in this case 😞 IMHO it's better to create separate issue specially for this to keep it in backlog at least.

@1ec5, we're ready to merge and to close #258 :wink:

cmahopper commented 4 years ago

@yuryleb Alright, thanks for the help anyway :)