Closed danpaz closed 9 months ago
What actually goes into {nth}
?
What actually goes into {nth}?
@tsuz Here's the logic that populates the {nth}
string: https://github.com/Project-OSRM/osrm-text-instructions/blob/master/index.js#L228
Basically:
{nth}
is replaced by an empty string{nth}
is replaced with one of these numbered strings from 1 to 10: https://github.com/Project-OSRM/osrm-text-instructions/blob/master/languages/translations/ja.json#L8-L17So after the replacement we will have these variations:
n | EN | JA |
---|---|---|
-- | You have arrived at your destination | 目的地に到着しました |
1 | You have arrived at your first destination | 1 つ目の目的地に到着しました |
2 | You have arrived at your second destination | 2 つ目の目的地に到着しました |
Do I simply upload this JSON document in the Transifex UI?
The usual workflow is to download a translatable JSON from Transifex, make your edits, and upload it back to Transifex. If that translatable JSON is similar enough, I guess you could skip the first step. But take care not to “translate” any strings with anything you’re unsure about.
I usually just add the translations in manually.
Ok, Transifex is now up to date.
Superseded by #312.
Issue
More follow up from #290 further improving our Japanese translations:
@1ec5 @yuryleb I have not synced these or previous changes with Transifex yet, let me know the best way to go about doing that. Do I simply upload this JSON document in the Transifex UI?
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?