Project-OSRM / osrm-text-instructions

Text instructions from OSRM route responses
BSD 2-Clause "Simplified" License
90 stars 63 forks source link

Japanese translation improvements #297

Closed danpaz closed 9 months ago

danpaz commented 4 years ago

Issue

More follow up from #290 further improving our Japanese translations:

@1ec5 @yuryleb I have not synced these or previous changes with Transifex yet, let me know the best way to go about doing that. Do I simply upload this JSON document in the Transifex UI?

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

tsuz commented 4 years ago

What actually goes into {nth}?

danpaz commented 4 years ago

What actually goes into {nth}?

@tsuz Here's the logic that populates the {nth} string: https://github.com/Project-OSRM/osrm-text-instructions/blob/master/index.js#L228

Basically:

So after the replacement we will have these variations:

n EN JA
-- You have arrived at your destination 目的地に到着しました
1 You have arrived at your first destination 1 つ目の目的地に到着しました
2 You have arrived at your second destination 2 つ目の目的地に到着しました
1ec5 commented 4 years ago

Do I simply upload this JSON document in the Transifex UI?

The usual workflow is to download a translatable JSON from Transifex, make your edits, and upload it back to Transifex. If that translatable JSON is similar enough, I guess you could skip the first step. But take care not to “translate” any strings with anything you’re unsure about.

1ec5 commented 4 years ago

I usually just add the translations in manually.

danpaz commented 4 years ago

Ok, Transifex is now up to date.

1ec5 commented 9 months ago

Superseded by #312.