search

Project-OSmOSE / OSEkit

OSEkit is an open source suite of tools written in python and dedicated to the management and analysis of data in underwater passive acoustics.
https://osmose.ifremer.fr
Other
3 stars 0 forks source link

Pc add simple previz util #139

Closed PaulCarvaillo closed 3 months ago

PaulCarvaillo commented 3 months ago

First PR to check if I can work from Marseille with the OSmose team.

changelog: -Added minimal spectrogram previsualisation tool to preprocessing utils. Inspired by the spectrogram_generator notebook, main difference is path management and I'm using the tempfile library for temporary dirs.

PaulCarvaillo commented 3 months ago

Note: the reason I pushed this is because I want to call this function directly in my demo notebook for the MMERMAID project.

cazaudo commented 3 months ago

nice try for a first PR @PaulCarvaillo !

but actually i am not sure the code you propose @PaulCarvaillo really belongs to the package as it does not really propose new functionalities but only uses existing methods

does it not correspond more to an example of external use of the package as it is done in https://project-osmose.github.io/osmose-toolkit/gallery_basic_use_cases/Spectrogram/2_tune_parameters.html#sphx-glr-gallery-basic-use-cases-spectrogram-2-tune-parameters-py ? whose code is here : https://github.com/Project-OSmOSE/osmose-toolkit/blob/main/docs/gallery_basic_use_cases/Spectrogram/2_tune_parameters.py

to me this contribution should rather go into a user guide notebook of this kind

however i will take the idea of using the tempfile library indeed this will be nicer than the built-int temp dir i made..

PaulCarvaillo commented 3 months ago

Alright then the code stays in the notebook where it was born x) Thx for the review.