Project-OSmOSE / OSEkit

OSEkit is an open source suite of tools written in python and dedicated to the management and analysis of data in underwater passive acoustics.
https://osmose.ifremer.fr
Other
3 stars 2 forks source link

Adding depth of hydrophone in metada. #73

Closed gmanatole closed 1 year ago

gmanatole commented 1 year ago

So far only latitude and longitude values are saved in metadata.csv However depth is an important parameter when analyzing audio.

cazaudo commented 1 year ago

hello @gmanatole and @MaelleTtrt i am starting working on this issue to integrate depth info at dataset building , different cases :

gmanatole commented 1 year ago

No mention of 'gps' in the name if the csv file ? Also, I would create the filename automatically wrt to the dataset filename.

cazaudo commented 1 year ago

i would let the user free to name the csv filename as he wants , can be gps.csv , depth.csv if only depth in it , or glider_aux.csv ........whatever , he puts the filename in the notebook depth = 'depth.csv' and we will search for it at dataset creation

but column names should be normalized so we can find them , lat , lon and depth are OK for you ?

cazaudo commented 1 year ago

i just created its PR and commited the code for the fixed hydro case, but perhaps @gmanatole it is best that you take care of the moving hydro as you have already worked on it ?