Closed gmanatole closed 11 months ago
Since it is meant to be added in the next major release of OSmOSE, the pull request should be against the develop branch rather than main.
hello githubers,
@gmanatole your notebook really runs on env_name = "osmose" ? i guess not
@Rumengol what means "against" in your message please ? not sure i understand
@cazaudo the notebook runs on osmose_dev
and branch auxiliary_data right ?
That's right.
And what @Rumengol meant is that I tried merging auxiliary_branch with main which is the sable branch as of now. I should have merged on develop and looked for conflicts with that branch as the Auxiliary class will be in version 2 that is being developed on that branch.
i am testing your codes on datarmor , here is a first series of questions / recommendations :
note that I have made some modifications directly on /home/datawork-osmose/osmose-datarmor/notebooks/auxiliary_variable_pkg.ipynb , be carefull it is not gitted..
code now working only for the case of a moving hydrophone, ie when provided a "gps.csv" file
@gmanatole at the beginning of this PR you have listed multiple scenarios, only scenario 4 is available, can you please implement the other 3 ?
REMARQUES
got it , it works now by redefining the following at the beginning of join_era() self.latitude=self.df.lat self.longitude=self.df.lon self.timestamps=self.df.time dirty but i will let it like that to make it explicit new order of methods: appli_weather = Auxiliary( ... ) appli_weather.join_welch() appli_weather.join_era() appli_weather.save_aux_data()
New class and module to join weather and environment data to an existing dataset.
NOTEBOOK TO TEST CLASS IS AVAILABLE IN '/home/datawork-osmose/osmose-datarmor/notebooks'
Multiple scenarios :