Project-Pandora-Game / pandora

https://project-pandora.com
Other
11 stars 2 forks source link

Tabs Style Fixes #670

Open Madmanmayson opened 6 months ago

Madmanmayson commented 6 months ago

The Tabulation component (found under commnon/tabs) may need needs styles updated to fix some consistency issues:

Edge alignment with no collapse button: image Edge alignment with collapse button: image

Current collapsed style: image

Concept with no border offset: image

Concept with border offset: image

ClaudiaMia commented 6 months ago

I see your point!

In these cases, I do not feel very strongly, but I think you raised this well documented issue because you feel it is not nice like it is and would like to improve it! You are also likely a much more experienced front end dev than us, so I am very happy that you show your creative vision here!

  1. I think it may be nice to streamline it so there is a padding on both sides. But I am not feeling strongly about any choice.

  2. I think that was an intentional design decision to have it square, but yes, ideally it should be a similarly behaving button and I am also personally fine with it being rounded.

  3. I think the first option is a bit more popping out an easier to notice, but it may look a bit unclean. Since the user likely knows there could be a tab bar there, since it starts not collapsed, I think it is fine to add the border offset.

UI design is something very personal and subjective in many cases, I feel. Here I would be happy if you follow what you think would speak a better front end design / usability language.