search

Project-Pandora-Game / pandora

https://project-pandora.com
Other
11 stars 3 forks source link

[FEATURE] Clickable links in account/character profiles #734

Closed Livie53 closed 4 months ago

Livie53 commented 4 months ago

Closes #711.

Splits profile descriptions by line to replace links with <UntrustedLink> elements. Consequently, currently only detects links when they're at the start of a line.

purpleharmony commented 4 months ago

The empty new file at pandora-client-web/src/ui/components/common/linkConverter.ts is probably not intentional

Livie53 commented 4 months ago

The empty new file at pandora-client-web/src/ui/components/common/linkConverter.ts is probably not intentional

Yeah, that was a file left from some testing that I guess got git add .'d with the rest, removed.

Livie53 commented 4 months ago

Thought of a different, imo better way to handle links in description, requested re-review due to changes.

E: Change includes detecting link in the middle of a line, and not taking the entire line as a link.