This PR changes the restrictions logic of transfer and move actions so that reordering of items within a single container is not treated as removing and re-adding the item. In this change it allows reordering items even if they cannot be removed.
Reordering locked item with relation to unlocked ones was possible before by simply reordering the unlocked ones freely, so this change only affects relative position of two locked items.
The reasoning behind this change is, that if two locked items shouldn't be reorder-able, there should already be a blocking relationship between them which prevents interactions with the item below. If the two items don't have attribute-based relationship, then they can be treated as separate and can be freely reordered.
Furthermore there is no real effect on restrictiveness, as the items still cannot be actually removed - the most common reason for reordering items is to fix layering problems, which we consider more important than the little bit of strictness from restricting this.
Changelog
Platform changes:
- Allowed reordering worn items that cannot be removed (e.g. locked items)
Checklist
[x] The change has been tested locally
[x] Added documentation to the new code and updated existing documentation where needed
References
None
About The Pull Request
This PR changes the restrictions logic of
transferandmoveactions so that reordering of items within a single container is not treated as removing and re-adding the item. In this change it allows reordering items even if they cannot be removed.Reordering locked item with relation to unlocked ones was possible before by simply reordering the unlocked ones freely, so this change only affects relative position of two locked items.
The reasoning behind this change is, that if two locked items shouldn't be reorder-able, there should already be a blocking relationship between them which prevents interactions with the item below. If the two items don't have attribute-based relationship, then they can be treated as separate and can be freely reordered. Furthermore there is no real effect on restrictiveness, as the items still cannot be actually removed - the most common reason for reordering items is to fix layering problems, which we consider more important than the little bit of strictness from restricting this.
Changelog
Checklist