Project-Path-of-Exile-Wiki / PyPoE

Collection of Python Tools for Path of Exile

GNU General Public License v3.0

24 stars 21 forks source link

Address 3.20.1 export issues from #102 #104

Open zao opened 1 year ago

zao commented 1 year ago

Abstract

Addresses some problems reported in #102 on legacy region watchstones, cosmetic type and theme.

Action Taken

All legacy watchstones are now skipped by list of IDs. Cosmetic type and theme has been moved to CurrencyItems and ShopTag, code updated to track the new data.

Caveats

Quest rewards not addressed yet, PR is WIP. Not sure if there's a more elegant way to skip the legacy watchstones en masse or a way to restore the old class name and keep them exportable.

FAO

@acbeaumo

acbeaumo commented 1 year ago

Caveat:

Alternate skill effects used to all be typed as "Skill Gem Effect". Now the value of the CosmeticTypeName field in CurrencyItems is different based on what gems it applies to. Ex1) Spirit Blink and Mirror Arrow Effect has the value "Blink and Mirror Arrow Skin". Ex2) Force Field Aura Effect has the value "Aura Skin".

The wiki's item template will need to be updated so that it doesn't error and to ensure that cosmetic items are categorized correctly.

zao commented 1 year ago

Quest rewards reintroduced by lifting the old export code for them and adapting it for DAT64 and changes in specs. There's a bunch of old hacks that may not be needed anymore.

I'm not certain how we want to handle rewards that involve Hard mode (Ruthless). I've tagged rewards with a difficulty field of any, normal, hard but don't know how that would affect consuming code on the wiki.

Exports currently look like this, haven't compared with past state: quest_rewards.txt