search

Project-Path-of-Exile-Wiki / PyPoE

Collection of Python Tools for Path of Exile
GNU General Public License v3.0
24 stars 21 forks source link

Fix Crafting Bench Export for 3.16 #47

Closed angelic-knight closed 2 years ago

angelic-knight commented 2 years ago 
DELETE THIS TEXT BOX BEFORE SUBMITTING THE PR.

When filling in the template, please delete the "filler" paragraph below the `# Header` 
portion and replace it with what the paragraph is asking from you. 
Keep these PR's nice and tidy and spend the time to write it out
properly. We will reject PR's that do not follow or fill in this template properly.

Abstract

I made updates so the crafting bench export will work with our 3.16 code base and the 3.16 ggpk.

Action Taken

Update CraftingBenchParser _DATA definitions to match the spec. Remove old hacky translation for sort category since it properly parses the .dat file now. Update the Cost_BaseItemTypes column reference to match changed name in spec. This fixes #41

Caveats

This does not fix issue #24. This works independently of the other PRs and changes.

FAO

@pm5k @Journeytojah @acbeaumo

angelic-knight commented 2 years ago

Found some more issues in this area tonight while updating the wiki. Fixed them and added them to this PR. Adding enchantment modifiers with a crafting bench was not supported. Previously, the unlock location was always based on the text description from the crafting recipe .dat. Now we fall back to the linked unlock area.