Project-Path-of-Exile-Wiki / PyPoE

Collection of Python Tools for Path of Exile
GNU General Public License v3.0
24 stars 21 forks source link

Passives Export - Remove Royale Passives and Flag Atlas Passives #52

Closed angelic-knight closed 2 years ago

angelic-knight commented 2 years ago

Abstract

I updated the passives export so it excludes Royale-specific passives. It also flags Atlas Passives to support easier filtering in queries.

Action Taken

I'm excluding Royale passives by excluding all passives whose Ids start with "royale". I'm flagging all passives whose Ids start with "atlas" as atlas passives. This flag becomes part of the Passive skill template markup that gets generated, as the parameter is_atlas_passive. These string comparisons are somewhat fragile, but I didn't see a flag in the .dat or a better way to do it.

We could exclude things with certain root nodes, but this does not seem worth the effort of parsing the skill trees. String prefixes are easy enough to identify and maintain.

Caveats

The passive skills module still needs to be updated to handle the new is_atlas_passive parameter. It should get a boolean field in the cargo table definition with the same name.

FAO

@pm5k @Journeytojah