search

Project-Path-of-Exile-Wiki / PyPoE

Collection of Python Tools for Path of Exile
GNU General Public License v3.0
24 stars 21 forks source link

Support for Sentinel Map Series & Duplicate Spec Field Name Validation #88

Closed angelic-knight closed 2 years ago

angelic-knight commented 2 years ago

Abstract

I made required updates so that the Sentinel Map Series could be exported to the wiki.
I also added a validation check to ensure you haven't added two fields with the same name to a .dat spec. Before if you did this, it would ignore the latter one and keep giving you the same .dat spec size mismatch error even though you tried to fix it.

Action Taken

I updated the .dat specs and the map series list in PyPoE.

Caveats

There are some assorted other .dat spec updates included in here, and one of them renames GrantedEffectsKey to GrantedEffect in GrantedEffectsPerLevel.dat, which will break skill gem exporting. However, skill gem exporting is very broken in this branch with and without this PR due to GGG's changes midway through 3.18.
I have another branch that fixes skill gem exporting.

FAO

@pm5k any thoughts on what kind of error should get thrown in fields.py?

angelic-knight commented 2 years ago

Note to self: Explore using an assertion instead of a ValueError.