Cargo won't update tables after edits are made to some items.

[Roggers-Bot]

This bug report was generated by Roggers, on behalf of angelic_knight.

Summary - Cargo Doesn't Update for Some Items

Cargo won't update tables after edits are made to some items.

Reproduction steps

[Write everything you did to make the bug/side-effect appear]

Expected outcome

[What was supposed to happen normally?]

Actual outcome

[What actually happened due to the bug]

Browser

[Name of your browser]

Browser version

[Version number of your browser]

Perceived impact

[How bad do you consider this to be on a scale from 1-10, be realistic - not hyperbolic]

Screenshots

[Attach screenshots at the end]

Screens

[angelic-knight]

If you make edits to the item template for some items, like https://www.poewiki.net/wiki/Oni-Goroshi, nothing gets reflected in the cargo tables. Deleting the entire contents of the page doesn't change the value of the cargo table entries for the page.

Making edits to other items works fine.

[angelic-knight]

https://www.poewiki.net/wiki/Gold_Ring has the same issue. It has multiple entries in item_mods which leads to Ventor's Gamble page breaking.

Same with https://www.poewiki.net/wiki/Royal_Staff - which breaks https://www.poewiki.net/wiki/The_Stormheart (for the mod issue in the item table, at least) - #107

Same with https://www.poewiki.net/wiki/Terror_Maul which breaks https://www.poewiki.net/wiki/Kongor%27s_Undying_Rage - #104

Same with Ritual Sceptre breaking Brutus' Lead Sprinkler - #97

Same with Whalebone Rapier and Goddess Bound - #109

[angelic-knight]

I might try regenerating the item_mods database, or maybe trying to delete the wonky table entries for these pages from the SQL.

I have no idea how items are getting into this state, but they all seem to have non-standard values in tables, and now they won't update when you save the page.

[jacquescorbytuech]

Just replicated on the Gold Ring page, neither null editing nor cache purges updated the stored values in the Cargo table.

[jacquescorbytuech]

Generating a replacement table via the cargoRecreateData script

[jacquescorbytuech]

Replacement table switched in.

[jacquescorbytuech]

Gold Ring still buggy, but I noticed it was getting errors from this divination card page https://www.poewiki.net/wiki/The_Opulent

I wonder if there's something happening upstream with dependencies that generates these errors.

[jacquescorbytuech]

Rebuilding the item_mods table to see if that changes anything

[jacquescorbytuech]

Nope, that didn't do anything either 🤔

[jacquescorbytuech]

Server error log when trying to null edit the page.

[Fri Oct 22 13:06:27.130783 2021] [proxy_fcgi:error] [pid 25646:tid 140190030599936] [client 89.39.137.154:43488] AH01071: Got error 'PHP message: PHP Deprecated: Use of InternalParseBeforeSanitize hook (used in VariablesHooks::onInternalParseBefore..............40597.cloudwaysapps.com/xuhdbanyws/public_html/w/includes/HookContainer/HookContainer.php at line 137] in /home/640597.cloudwaysapps.com/xuhdbanyws/public_html/w/includes/debug/MWDebug.php on line 376', referer: https://www.poewiki.net/wiki/Gold_Ring
[Fri Oct 22 13:06:29.279653 2021] [proxy_fcgi:error] [pid 25646:tid 140190122919680] [client 89.39.137.154:43620] AH01071: Got error 'PHP message: PHP Deprecated: Use of InternalParseBeforeSanitize hook (used in VariablesHooks::onInternalParseBefore...............cloudwaysapps.com/xuhdbanyws/public_html/w/includes/HookContainer/HookContainer.php at line 137] in /home/640597.cloudwaysapps.com/xuhdbanyws/public_html/w/includes/debug/MWDebug.php on line 376', referer: https://www.poewiki.net/wiki/edit/Gold_Ring
[Fri Oct 22 13:06:29.432711 2021] [proxy_fcgi:error] [pid 25646:tid 140190869870336] [client 89.39.137.154:43620] AH01071: Got error 'PHP message: PHP Deprecated: Use of InternalParseBeforeSanitize hook (used in VariablesHooks::onInternalParseBefore...............cloudwaysapps.com/xuhdbanyws/public_html/w/includes/HookContainer/HookContainer.php at line 137] in /home/640597.cloudwaysapps.com/xuhdbanyws/public_html/w/includes/debug/MWDebug.php on line 376', referer: https://www.poewiki.net/wiki/edit/Gold_Ring

[angelic-knight]

https://m.mediawiki.org/wiki/Manual:Hooks/InternalParseBeforeSanitize Deprecated indeed. This has suggestions for alternatives.

If it's only happening for some pages, it's strange that code paths differ.

[jacquescorbytuech]

Unfortunately the hook is being used by the Variables extension https://www.mediawiki.org/wiki/Extension:Variables

We'd need to find a way around that error, and I'm not entirely sure the error is actually causing the bug on that page as it's triggered elsewhere without problems.

[angelic-knight]

Recreating item_mods did at least fix the issue of duplicate entries for the implicit mods, allowing the unique versions' item cards to generate.

[jacquescorbytuech]

Yeah, I can still see some weird errors though, for example with Andvarius here https://www.poewiki.net/wiki/Race_season_6 and item acquisition on the Andvarius page itself https://www.poewiki.net/wiki/Andvarius

[angelic-knight]

Looks like the uniques from these bases aren't getting entries in the items table. Very odd...

Perhaps Cargo is bugging out

[angelic-knight]

I'm unable to affect cargo tables by editing other random item pages, like Bloodseeker and Bloodboil.

Playing around on https://www.poewiki.net/wiki/Template:Item/testcases works fine though.

[acbeaumo]

Can anyone verify whether this is still an issue?

[jacquescorbytuech]

Appears fixed on the Gold ring page.

[angelic-knight]

I concur. My edits on a page that previously weren't working are now updating cargo tables.

[acbeaumo]

So it looks like rebuilding the Cargo tables fixed it, as expected. I'm closing this ticket.