Open roggers-the-bot opened 1 year ago
Correction: this does not appear to be a super new issue: https://www.poewiki.net/index.php?title=Passive_Skill%3AAscendancyAscendant35&type=revision&diff=1204384&oldid=1168458 The bot had the same issues last year too, so prioritizing a way to have the bot skip auto-updating these pages would be best, I think.
l think the stat text is now correct https://www.poewiki.net/wiki/Passive_Skill:AscendancyDeadeye14, but the reminder text is still not coming through, as it's linked from the translation file rather than directly from the PassiveSkills table.
It doesn't look like passive skill reminder text is used though: Crave the Slaughter has reminder text but it's only visible on the raw passive skill page, not on the Berserker Ascendancy or the Crave the Slaughter article it links to.
It also looks like it would be challenging to format multiple lines of reminder text correctly. If we want to make that information available maybe a better option would be to put the stat text through the make_inter_wiki_links
function to create direct links to the relevant articles.
I've created a separate issue for mod stat text, as fixing that may require some exploration of the data files.
Main issues are resolved; reminder text not appearing may be difficult to fix and not a priority.
Describe the bug:
New data for several stats that have an "aura-like" effect causing issues in combined stat_text/reminder_text where the aura's effect is shown and worded as if applying to the player. Additionally, some reminder text are being removed incorrectly:
Passive Skill:AscendancyDeadeye14 -|reminder_text = (Tailwind increase Action Speed by 8%)
(Each instance of Gale Force lasts 4 seconds. Maximum 10 Gale Force) -|stat_text = Gain 1 Gale Force when you use a Skill
15% increased Effect of Tailwind on you per Gale Force
You and nearby Allies have [[Tailwind]] +|stat_text = Gain 1 Gale Force when you use a Skill
15% increased Effect of Tailwind on you per Gale Force
8% increased Action Speed
You and nearby Allies have Tailwind
The new data incorrectly implies players will gain 8% increased Action Speed on top of the Tailwind, which is incorrect. https://i.imgur.com/qht3pTx.png
Other examples: Passive Skill:AscendancyAscendant35
Unrelated but similar issue: https://www.poewiki.net/wiki/Modifier:NearbyEnemyZeroChaosDamageResistanceUnique~~1 This modifier incorrectly lists the aura effect as a stat, incorrectly implying the player's Chaos Resistance is 0.
Reproduction steps:
https://gist.github.com/zao/5064d4731230edc373023e29e882d4c5
Solution likely one of the following: 1) Check the export mechanism to see why there are issues with the reminder_text being missing or merged into stat_text 2) Figure out a way for the bot to skip updating the above pages when exporting PASSIVE SKILL data due to loss of/incorrect information. Currently, only ITEMS have an exclusion list.
Refer to Jasmine and Zao for further details https://discord.com/channels/872882365406523452/877595309792968715/1069178987399614525
Browser Used:
Google Chrome
Bug Severity:
8