search

Project-Pier / ProjectPier-Core

ProjectPier is a Free, Open-Source, PHP application for managing tasks, projects and teams through an intuitive web interface.
http://www.projectpier.org
GNU Affero General Public License v3.0
37 stars 16 forks source link

I'm not following the pupose of SHA: 1c7f68bce2cf9f551387cfafddb47d430246d255 adding a user locale field to the user profile. #24

Open JonDeG opened 9 years ago

JonDeG commented 9 years ago

The commit message for SHA: 1c7f68bce2cf9f551387cfafddb47d430246d255 makes it sound like this is going to send emails in the user's locale language, but it doesn't actually do that. I see no further commits related to finishing this feature (maybe I'm overlooking it). Perhaps this commit was just setting it up for later? I'm not sure how the user is supposed to know what to enter in this field, it should be a drop-down list of locales that are available. Unless someone can shed some light on this, I'm inclined to remove this field/feature.

Engelbert commented 9 years ago

:+1: on "removing" it for now. (commenting it out seems the logical thing to do.)

Engelbert commented 9 years ago

This function is not production ready imo. Let's comment the locale field out and add a TODO marker/comment to it.