search

Project-Pier / ProjectPier-Plugin-Tickets

A tickets plugin for ProjectPier
0 stars 1 forks source link

Closing a ticket does not change its state just its status (no filtering on closed!) #2

Open mdkaleel opened 9 years ago

mdkaleel commented 9 years ago

I have some Closed Ticket & Open, when it try view only closed by Filter option its not showing Closed item & its appearing when i click all Tickets

Filter is not working : Reported By, Assigned to. Check All Menus

In All Tickets, if i sort by clicking Status its not Shorting.

Engelbert commented 9 years ago

The filters seem to work for me, except for the "Closed" filter. I think that when closing the ticket there should be a flag set of closed, this however does not happen. It keeps its former state. @mdkaleel : can you test this for me please?

:memo: :You do have to remember that by clicking a filter you are adding it to the list of items to filter on. There is a little minus sign after the clicked filter to remove it again from that list. (That minus sign should be made more visible imo, and the active filter should be bold or something. But I guess that is another issue. :smiley: )

mdkaleel commented 9 years ago

@Engelbert Tryed :( , Not Working , pp_tick_with_closed_st pp_tick_with_closed_st_filter

Engelbert commented 9 years ago

@mdkaleel : What was the previous state of the closed ticket with id: 8 ? I bet if you filter on that status it'll show up.

Engelbert commented 9 years ago

Here is a screenshot @mdkaleel . It shows the ticket as Closed but I am sorting on Fixed (and everything else too...). So it definitely is not working as it should be. I'll have a look mate. :smile_cat: screenshot from 2015-01-21 11 21 31

mdkaleel commented 9 years ago

is it Ticket we can send in HTML Format ...?

Notifier.class.php Line:578

static function sendEmail($to, $from, $subject, $body = false, $type = 'text/html', $encoding = '')

Engelbert commented 9 years ago

In the future these kind of questions should be asked in the forum. It has nothing to do with this issue. But here is your answer: yes you could do that. but you would have to change the notifier templates too then! They are located @ ProjectPier-Core/application/views/notifier/ Big advantage of what we do now is that it'll look almost the same on every device/client/... If you go the html way... who knows what'll happen with your message in online Gmail or Outlook? What is your IPhone going to show you? And so on.

If I were you I wouldn't go html, you'll get a nice result if you just change/revamp the current templates.

Engelbert commented 9 years ago

http://www.projectpier.org/node/2195 more info on this bug