scottjr632
commented
1 year ago Looks like the jest snapshot tests are failing, can you update them by running npm run test -- -u?
Closed 4-Leafs-Code closed 1 year ago
scottjr632
commented
1 year ago Looks like the jest snapshot tests are failing, can you update them by running npm run test -- -u?
4-Leafs-Code
commented
1 year ago this is what I got: what do I push
No tests found related to files changed since last commit.
Press a to run all tests, or run Jest with --watchAll.
Watch Usage › Press a to run all tests. › Press f to run only failed tests. › Press q to quit watch mode. › Press p to filter by a filename regex pattern. › Press t to filter by a test name regex pattern. › Press Enter to trigger a test run.
From: Scott Richardson @.> Sent: Monday, November 21, 2022 9:52 PM To: Project-Reclass/toynet-react @.> Cc: Clover S. Baxter @.>; State change @.> Subject: Re: [Project-Reclass/toynet-react] Update maxW of Lectures and Articles to 700px #283 (PR #327)
CAUTION: This email originated from outside your organization. Exercise caution when opening attachments or clicking links, especially from unknown senders.
Looks like the jest snapshot tests are failing, can you update them by running npm run test -- -u?
— Reply to this email directly, view it on GitHubhttps://github.com/Project-Reclass/toynet-react/pull/327#issuecomment-1322956842, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZIURO4MVO5TR5TDLT3G7ZDWJQYP7ANCNFSM6AAAAAASFE2NLM. You are receiving this because you modified the open/close state.Message ID: @.***>
4-Leafs-Code
commented
1 year ago Okay, I have created a new pull request. After I updated everything, changed the code, I ran npm test and passed everything still.
But the 2 .jsons were included in my pull request and it wouldn't let me remove them. Is this going to be a problem?
It's not a PR only a commit to my fork but please ignore the migrateSplashHeader. I'm not finished with that yet. I still have to fix the button size.
From: Scott Richardson @.> Sent: Monday, November 21, 2022 10:16 PM To: Project-Reclass/toynet-react @.> Cc: Clover S. Baxter @.>; State change @.> Subject: Re: [Project-Reclass/toynet-react] Update maxW of Lectures and Articles to 700px #283 (PR #327)
CAUTION: This email originated from outside your organization. Exercise caution when opening attachments or clicking links, especially from unknown senders.
@scottjr632 approved this pull request.
LGTM, just update the snapshots and we can merge 🙂
— Reply to this email directly, view it on GitHubhttps://github.com/Project-Reclass/toynet-react/pull/327#pullrequestreview-1189262107, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZIURO2UIGIECY6WWNTFIHLWJQZETANCNFSM6AAAAAASFE2NLM. You are receiving this because you modified the open/close state.Message ID: @.***>
4-Leafs-Code
commented
1 year ago I'm watching the test. 😓 This this is so touchy. What am I doing wrong?
From: Clover S. Baxter @.> Sent: Monday, November 21, 2022 10:42 PM To: Project-Reclass/toynet-react @.> Subject: Re: [Project-Reclass/toynet-react] Update maxW of Lectures and Articles to 700px #283 (PR #327)
Okay, I have created a new pull request. After I updated everything, changed the code, I ran npm test and passed everything still.
But the 2 .jsons were included in my pull request and it wouldn't let me remove them. Is this going to be a problem?
It's not a PR only a commit to my fork but please ignore the migrateSplashHeader. I'm not finished with that yet. I still have to fix the button size.
From: Scott Richardson @.> Sent: Monday, November 21, 2022 10:16 PM To: Project-Reclass/toynet-react @.> Cc: Clover S. Baxter @.>; State change @.> Subject: Re: [Project-Reclass/toynet-react] Update maxW of Lectures and Articles to 700px #283 (PR #327)
CAUTION: This email originated from outside your organization. Exercise caution when opening attachments or clicking links, especially from unknown senders.
@scottjr632 approved this pull request.
LGTM, just update the snapshots and we can merge 🙂
— Reply to this email directly, view it on GitHubhttps://github.com/Project-Reclass/toynet-react/pull/327#pullrequestreview-1189262107, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZIURO2UIGIECY6WWNTFIHLWJQZETANCNFSM6AAAAAASFE2NLM. You are receiving this because you modified the open/close state.Message ID: @.***>
Updated the maxW of Lectures and Articles to 700px
Resolves Issue: closes #283