4-Leafs-Code
commented
1 year ago I just pulled my main fork to gitpod and followed developer setup instructions. Then ran npm run test -- -u
Now Ill make a branch and try the monospace.... brb
Test Suites: 30 passed, 30 total Tests: 110 passed, 110 total Snapshots: 19 passed, 19 total Time: 19.015 s Ran all test suites.
Watch Usage: Press w to show more.
From: Scott Richardson @.> Sent: Monday, November 21, 2022 9:51 PM To: Project-Reclass/toynet-react @.> Cc: Clover S. Baxter @.>; Author @.> Subject: Re: [Project-Reclass/toynet-react] Change the font of IP addresses to be monotype (PR #328)
CAUTION: This email originated from outside your organization. Exercise caution when opening attachments or clicking links, especially from unknown senders.
@scottjr632 commented on this pull request.
In src/Emulator/Drawer/CreateHostView.tsxhttps://github.com/Project-Reclass/toynet-react/pull/328#discussion_r1028776326:
@@ -150,6 +150,7 @@ export default function CreateHostView({ nameHint }: Props) {
<FormControl>
<FormLabel>IP Address</FormLabel>
<SpaceSanitizedInput- fontFamily='monotype'
Try monospace instead and see how that looks 🙂
⬇️ Suggested change
-
fontFamily='monotype'
-
fontFamily='monospace'
In src/Emulator/Drawer/CreateRouterView.tsxhttps://github.com/Project-Reclass/toynet-react/pull/328#discussion_r1028776481:
@@ -145,6 +145,7 @@ export default function CreateRouterView({ nameHint }: Props) {
<FormControl>
<FormLabel>IP Address</FormLabel>
<SpaceSanitizedInput- fontFamily='monotype'
Same as above comment
— Reply to this email directly, view it on GitHubhttps://github.com/Project-Reclass/toynet-react/pull/328#pullrequestreview-1189257843, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZIURO6SB2ACN35XTLDLGNLWJQYMBANCNFSM6AAAAAASGHHLVY. You are receiving this because you authored the thread.Message ID: @.***>
Description
Changed the font of IP address inputs to fontFamily='monotype' for Host and Router in the emulator.
When I ran "style:check", I am only getting the same 2 unused variables. Everything else is working.
Resolves Issue: closes #287.