Project-Sloth / ps-fuel

A NoPixel inspired functionality fuel system that uses PolyZones that target specific areas that allow you to have the abilitity to refuel your vehicles.
GNU General Public License v3.0
75 stars 52 forks source link

[Bug] Multiple issues #3

Closed nzkfc closed 2 years ago

nzkfc commented 2 years ago

There seems to be a few issues that need looking at potentially. I have already submitted the arithmatic error, here are some oddities I noticed as well as our players:

  1. Refueling estimates a cost, however it charges what is set in config.lua e.g. Config.refuelCost = 600

  2. When refueling the car it seems to work fine, however the native gta ammo seems to be misaligned to the item durability which is being used as some sort of quantity remaining function? Pouring the fuel out onto the ground seems to run out way to quickly on the durability but native ammo doesn't match as well as the item ammo in inventory?

  3. Seems to get confused sometimes and aims it like a pistol?

  4. Seems to randomly pour out after refilling the can.

Here is a clip, might need to pause now and then to review the ammo qty etc to make it make sense: https://drive.google.com/file/d/1T2xpAe--15H5JycAS0tgdWxu6VfYoxeG/view?usp=sharing

maguhd commented 2 years ago

In qb-weapons you gotta add weapon_petrolcan in Config.DurabilityBlockedWeapons and remove it from Config.DurabilityMultiplier.

MonkeyWhisper commented 2 years ago

Is this still an issue?

There seems to be a few issues that need looking at potentially. I have already submitted the arithmatic error, here are some oddities I noticed as well as our players:

  1. Refueling estimates a cost, however it charges what is set in config.lua e.g. Config.refuelCost = 600
  2. When refueling the car it seems to work fine, however the native gta ammo seems to be misaligned to the item durability which is being used as some sort of quantity remaining function? Pouring the fuel out onto the ground seems to run out way to quickly on the durability but native ammo doesn't match as well as the item ammo in inventory?
  3. Seems to get confused sometimes and aims it like a pistol?
  4. Seems to randomly pour out after refilling the can.

Here is a clip, might need to pause now and then to review the ammo qty etc to make it make sense: https://drive.google.com/file/d/1T2xpAe--15H5JycAS0tgdWxu6VfYoxeG/view?usp=sharing

nzkfc commented 2 years ago

I'll double check tonight for you and confirm. I know the arithmetic bug is constantly happening but I get told not to post it here and then when I post it to support in discord its not looked at. One person mentioned to look into custom categories in qb-core for vehicles.lua but I'm not sure what else from there.

On Tue, 23 Aug 2022, 3:22 am MonkeyWhisper, @.***> wrote:

Is this still an issue?

There seems to be a few issues that need looking at potentially. I have already submitted the arithmatic error, here are some oddities I noticed as well as our players:

  1. Refueling estimates a cost, however it charges what is set in config.lua e.g. Config.refuelCost = 600
  2. When refueling the car it seems to work fine, however the native gta ammo seems to be misaligned to the item durability which is being used as some sort of quantity remaining function? Pouring the fuel out onto the ground seems to run out way to quickly on the durability but native ammo doesn't match as well as the item ammo in inventory?
  3. Seems to get confused sometimes and aims it like a pistol?
  4. Seems to randomly pour out after refilling the can.

Here is a clip, might need to pause now and then to review the ammo qty etc to make it make sense: https://drive.google.com/file/d/1T2xpAe--15H5JycAS0tgdWxu6VfYoxeG/view?usp=sharing

— Reply to this email directly, view it on GitHub https://github.com/Project-Sloth/ps-fuel/issues/3#issuecomment-1222510178, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGHUHL4UUHBJ4S4I36DUBLV2OLJXANCNFSM5W4773PQ . You are receiving this because you authored the thread.Message ID: @.***>

nzkfc commented 2 years ago

Is this still an issue?

There seems to be a few issues that need looking at potentially. I have already submitted the arithmatic error, here are some oddities I noticed as well as our players:

  1. Refueling estimates a cost, however it charges what is set in config.lua e.g. Config.refuelCost = 600
  2. When refueling the car it seems to work fine, however the native gta ammo seems to be misaligned to the item durability which is being used as some sort of quantity remaining function? Pouring the fuel out onto the ground seems to run out way to quickly on the durability but native ammo doesn't match as well as the item ammo in inventory?
  3. Seems to get confused sometimes and aims it like a pistol?
  4. Seems to randomly pour out after refilling the can.

Here is a clip, might need to pause now and then to review the ammo qty etc to make it make sense: https://drive.google.com/file/d/1T2xpAe--15H5JycAS0tgdWxu6VfYoxeG/view?usp=sharing

Yep so working find now, the only thing outstanding is the arithmetic bug, but it's to do with custom categories of cars from vehicles.lua, so there must be a way to incorporate custom categories for the script to work with vehicles.lua

MonkeyWhisper commented 2 years ago

Is this still an issue?

There seems to be a few issues that need looking at potentially. I have already submitted the arithmatic error, here are some oddities I noticed as well as our players:

  1. Refueling estimates a cost, however it charges what is set in config.lua e.g. Config.refuelCost = 600
  2. When refueling the car it seems to work fine, however the native gta ammo seems to be misaligned to the item durability which is being used as some sort of quantity remaining function? Pouring the fuel out onto the ground seems to run out way to quickly on the durability but native ammo doesn't match as well as the item ammo in inventory?
  3. Seems to get confused sometimes and aims it like a pistol?
  4. Seems to randomly pour out after refilling the can.

Here is a clip, might need to pause now and then to review the ammo qty etc to make it make sense: https://drive.google.com/file/d/1T2xpAe--15H5JycAS0tgdWxu6VfYoxeG/view?usp=sharing

Yep so working find now, the only thing outstanding is the arithmetic bug, but it's to do with custom categories of cars from vehicles.lua, so there must be a way to incorporate custom categories for the script to work with vehicles.lua

Hmm. Can you share more info on this? The only way this will occur if it's it does not have the proper name on the metadata and on QBCore shared vehicles, meaning the categories to matching qbcore share

nzkfc commented 2 years ago

Yeah so as an example of a vehicle that has a custom category:


    ['dragoon'] = {                                                 
        ['name'] = 'Dragoon (Warriors)',
        ['brand'] = 'Motorcycle',
        ['model'] = 'dragoon',
        ['price'] = 75000,
        ['category'] = 'gangbike',
        ['hash'] = `dragoon`,
        ['shop'] = 'motorcycleshop',
    },```