search

Project-Stage-Academy / UA-1131_Forum-PS

0 stars 0 forks source link

16-implementing-project-information-update-functionality #67

Closed ydmyterko closed 7 months ago

ydmyterko commented 7 months ago

The following changes are done:

point #2 API Endpoint Development: Develop robust API endpoints to handle GET and POST requests for updating project information.

point #5 Revision History Feature: Develop a backend solution to track and store the history of changes made to the project information.

YanZhylavy commented 7 months ago

Here you've simplified the endpoints related to companies to the maximum, using a ViewSet and the permission applied to it. However, there are some controversial points, for example, a user who has no relation to a specific company is forbidden even to retrieve information about it via the GET method ('companies/1), although at the same time, they can retrieve this information by making a GET request for all companies together (companies/), which is somewhat illogical. Overall, this isn't a major issue, but it could be a subject for consideration or discussion regarding some refinement and clarification in the views.

ydmyterko commented 7 months ago

Here you've simplified the endpoints related to companies to the maximum, using a ViewSet and the permission applied to it. However, there are some controversial points, for example, a user who has no relation to a specific company is forbidden even to retrieve information about it via the GET method ('companies/1), although at the same time, they can retrieve this information by making a GET request for all companies together (companies/), which is somewhat illogical. Overall, this isn't a major issue, but it could be a subject for consideration or discussion regarding some refinement and clarification in the views.

Hi Yan. Here the logic it that only the user, who's the Company member can see all Companies to which it belongs and can edit Company profile.