#30 admin enpoints - Githubissues

Project-Yicem / Yicem-backend

Backend application of Yicem

0 stars 0 forks source link

#30 admin enpoints #35

Closed AlperenYilmazyildiz closed 2 months ago

AlperenYilmazyildiz commented 2 months ago

Implemented "/api/admin/approve-seller" endpoint and implement logic as new sellers will be flagged as unapproved and will not be able to log in until it is approved. AuthController is updated, unapproved sellers cannot sign in now.
Implemented "/api/admin/delete-buyer"
Implemented "/api/admin/delete-seller"
Implemented "/api/admin/delete-review"

oburakdogan commented 2 months ago

[x] Delete Review endpoint should update the seller's rating.
[x] Delete Buyer endpoint will delete Buyer's Reservations from both DB and related Offer's Reservation List. You can copy BuyerService's cancelReservation function for Buyer's activeReservations before deleting Buyer.
[x] Delete Seller endpoint deletes Seller and Seller's offers successfully. But it should also delete Reservations of this Seller's Offers from both DB and related Buyers' activeReservations List. Again, you can copy BuyerService's cancelReservation for that since it deletes Reservation from both Buyer's List and DB.

AlperenYilmazyildiz commented 2 months ago

Why are there multiple space changes without any functional change in the SellerService file, are those the changes that causing a merge conflict? Intellij fixes indentation automatically with control+alt+L, space changes because of this. They are not causing merge conflicts right now. I think Burak made changes in getOffers and markOfferSold functions. I did not tested them in my branch yet so did not resolve those conficts yet.

In the deleteSeller method, checking the existence of the offer by first getting it as an Optional object might be a good idea. Since it does not causes troubles and we have limited time, I think we can skip it right now.