Project31 / ansible-kubernetes-openshift-pi3

Ansible playbooks for setting up a Kubernetes Raspberry Pi 3 cluster
190 stars 55 forks source link

Fix typo for SSH key path #10

Closed MathiasRenner closed 7 years ago

MathiasRenner commented 7 years ago

When running the basic setup with

ansible-playbook -k -i hosts setup.yml

... Ansible throws this error without this fix:

FAILED! => {"changed": false, "failed": true, "msg": "could not find src=/home/mac/.ssh/id_dsa.pub"}

This PR fixes the error.

rhuss commented 7 years ago

Well, that of course depends which kind of ssh key you are using. A DSA is also a perfectly valid choice for a key ;-). The error indeed is, that its hardcoded to .dsa and should be more flexible, maybe even by copying every pub key found over to the pis.

MathiasRenner commented 7 years ago

This was new for me, thanks for the info :)

I don't know how easy it is to implement your idea (copying all keys). I found this module, which allows to create a new key if it does not exist. Drawback: You can specify DSA or RSA only exclusively.

This probably works, but I won't take the time to look further into this issue.

kenden commented 7 years ago

This seems to be relevant: http://security.stackexchange.com/questions/112802/why-openssh-deprecated-dsa-keys If dsa gets deprecated, I would be better to use id_rsa instead of id_dsa.

rhuss commented 7 years ago

You are all right, just switched to id_dsa with the latest update (which btw now uses kubeadm and Kubernetes 1.5.1)