Project60 / org.project60.banking

CiviCRM banking extension
18 stars 35 forks source link

Search / filter list of statements not working #348

Open webmaster-cses-org-uk opened 2 years ago

webmaster-cses-org-uk commented 2 years ago

Attempting to search or filter the list of statements ("Include completed statements", filter by bank account, filter on date) does not work because the form submission URL is broken.

I found a quick fix which is simply to change the form method from GET to POST, which works absolutely fine. Longer-term, it may be better to use a CiviCRM Form object to render the form rather than code manually in the template?

Anyway, changing line 3 of templates/CRM/Banking/Page/Statements.tpl as follows fixes the issue:

<form action="" method="get">

change to:

<form action="" method="post">
webmaster-cses-org-uk commented 2 years ago

Created https://github.com/Project60/org.project60.banking/pull/349 to incorporate this.

Tested and working on CiviCRM 5.37.0.