search

Project60 / org.project60.banking

CiviCRM banking extension
18 stars 35 forks source link

Existing contributions matcher: Partial and incorrect payments are closing existing contributions #400

Open thomasrenner opened 1 year ago

thomasrenner commented 1 year ago

Problem: A payment with an amount greater than zero, that is registered by civiBanking, automatically closes an existing contribution, no matter if the payment amount matches the contribution amount or not. The status of the contribution is automatically set to "completed". This is especially problematic if the payment is not a donation, but corresponds to e.g. an event fee or a membership fee. We have attached 2 patches, that have basically fixed the Problem for us and that we would kindly ask for to be reviewed. These patches were created during CiviSprint Leipzig 2023

Similar issue from 2020: https://github.com/Project60/org.project60.banking/issues/298

civibanking_partial_payment_defaultOptionMatcher.patch civibanking_partial_payment_ExistingContributionMatcher.patch

eptbertram commented 5 months ago

Hej @thomasrenner , how to test those patches? Since I'm a noob I'll need some copy&paste-advice ;)