Project60 / org.project60.membership

CiviCRM extension to facilitate the "European" membership concept
GNU Affero General Public License v3.0
6 stars 14 forks source link

Use correct markup for forms and pages #41

Open jensschuppe opened 4 years ago

jensschuppe commented 4 years ago

The templates should use correct markup structure and CSS classes for elements to be displayed correctly with the CiviCRM Core design as well as org.civicrm.shoreditch.

An example for when this fails with Shoreditch, is the form at civicrm/membership/payments: membership_design_flaws

It should display like this: membership_design_correct

This involves (incomplete):

bjendres commented 4 years ago

@jensschuppe care to provide a PR?

jensschuppe commented 4 years ago

Sure, can you confirm that one beforehand?

making the page path contain civicrm/admin/ so that admin-related styles are applied (I guess those forms are not meant to be public)

... so as to not break anything (permission-like).

bjendres commented 4 years ago

civicrm/membership/payments is meant for users not just for admins.