search

Project60 / org.project60.membership

CiviCRM extension to facilitate the "European" membership concept
GNU Affero General Public License v3.0
6 stars 14 forks source link

Remove deprecated function calls #46

Closed jensschuppe closed 4 years ago

jensschuppe commented 4 years ago

At least split() is being used in the current code, e.g. here: https://github.com/Project60/org.project60.membership/blob/91fc74179f62ab79a68a7700237fc1b79ecdd6da/api/v3/Membership/Extend.php#L298

This function had been deprecated since PHP 5.3.0 and removed since PHP 7.0.0.

jensschuppe commented 4 years ago

This should be easy using explode() instead.

jensschuppe commented 4 years ago

Also, that seems to be the only occurence of incompatible language elements, according to a PHPStorm code inspection on the current new_master branch (91fc74179f62ab79a68a7700237fc1b79ecdd6da).

bjendres commented 4 years ago

@jensschuppe go ahead and fix it there. I'ts called new_master after a merge mishap, we can rename soon...

bjendres commented 4 years ago

@jensschuppe feel free to create an alpha-release

jensschuppe commented 4 years ago

@bjendres I don't have write access or whatever permission is needed for releases, so that'd be your task ;)