search

Project60 / org.project60.sepa

SEPA direct debit integration with civicrm
19 stars 46 forks source link

Error message not displayed when using AJAX-based pop-up editing #393

Closed peth-systopia closed 7 years ago

peth-systopia commented 8 years ago

If you want to delete a contribution that is linked to a mandate, an error message should be displayed that this is not possible (as well as the ID of the linked mandate). However, if you use AJAX-based pop-up editing, the error is not displayed, but the form just keeps loading.

Fabian-SYSTOPIA commented 7 years ago

Can confirm this still happens on 4.7

Fabian-SYSTOPIA commented 7 years ago

The problem still seems to exist (using 1.2.4 alpha & CiviCRM 4.7.13 and 4.6.21)

bjendres commented 7 years ago

Well, with https://github.com/Project60/org.project60.sepa/commit/4521c843808eeb195526260b843ebd4a9b13c4db we now produce a proper exception, I added an APIWrapper to return a proper API error, and also added a feature that would remove the 'delete' link in a contribution search result.

The problem is, however, that the AJAX calls from the UI do not use the API and cannot deal with an exception on the server side. I will create an official ticket, this needs to be fixed in core.

bjendres commented 7 years ago

There was still an issue with this, some calls needed an extra include. Should be fixed with https://github.com/Project60/org.project60.sepa/commit/c1df885b8b146ea3f85434d014b73bc5e3d70cd5 in 1.2.4.beta2