Changing the status of the recurring contribution to "in progress"

Project60 / org.project60.sepa

SEPA direct debit integration with civicrm

19 stars 46 forks source link

Changing the status of the recurring contribution to "in progress" #416

Open tttp opened 7 years ago

tttp commented 7 years ago

hi, Right now, the status of the recurring contributions are "pending" (if created or runnning) or "completed" (if finished)

It's rather confusing for the users to "translate", @systopia I'd like to use other status:

"pending" from the creation until the first time the account has been debited (xml file has been "marked received")
"in progress" as long as the account is debited
"Cancelled" or "Failed" when closing the mandate. Right now, we don't distinguish why we cancel or set and end date, so I'd suggest to always set "cancelled"

What do you think? should make it more readable, isn't it?

bjendres commented 7 years ago

Hi @tttp. Sorry for the late reply, I was on holiday.

I agree that the selection of statuses is not very good, and I agree with the proposed use of pending and in progress. However I would want to keep completed for mandates that had limited runtime from the beginning. I could also see us using cancelled and failed, but here we need to properly define its meaning.

In any case, this is obviously not done by simply changing batching code, but we also need to adjust all the interfaces (e.g. mandate actions) and reporting functions, and create update code for migration. PRs very welcome, but I very likely don't have time for that atm.

bjendres commented 6 years ago

I implemented the change in branch dev_416, and an active recurring_contribution will now always be in status 'in Progress' instead of 'Pending'. However, I haven't implemented the idea, to leave the recurring_contribution in 'Pending' until the first collection - feel free to add that if you want....

@tttp Could you test this?

bjendres commented 6 months ago

@pfigel Is this still relevant for you? GP ticket is [12748]