search

Project60 / org.project60.sepa

SEPA direct debit integration with civicrm
19 stars 46 forks source link

Add CBIBdySDDReq_00_01_00 SEPA format #664

Closed masetto closed 1 year ago

masetto commented 1 year ago

The CBIBdySDDReq is a XML format used by Italian banks and requires a new setting field called "CUC-code".

masetto commented 1 year ago

In the CUC field I removed the default value 'SEPATEST' and added a clarification in the label. Is it ok for you? I do not know how to add a placeholder....

For unit tests please give me a starting point to take inspiration from?

bjendres commented 1 year ago

For unit tests please give me a starting point to take inspiration from?

You're right. I thought we already had some, but I think I was confusing that with another project. I created #665 to not forget about this. But I don't expect you to do that yourself, unless you're really motivated.

I think the next step would be for me to try this out locally and see if I can spot any more issues.

If everything goes well, I'll merge and tag a 1.8-alpha version for you.

bjendres commented 1 year ago

@masetto I have merged your PR and tagged it as 1.9-alpha1.

Could you please confirm that this works? Specifically in the "newly installed" and the "upgrade from 1.8.x" scenarios?

masetto commented 1 year ago

@bjendres I confirm that the upgrade from version 1.8.0 to 1.9-alpha1 works well.

bjendres commented 1 year ago

@bjendres I confirm that the upgrade from version 1.8.0 to 1.9-alpha1 works well.

Great. And your new file format works, too - right?

masetto commented 1 year ago

of course :smiley: we have already sent contributions to the bank.