search

Project60 / org.project60.sepa

SEPA direct debit integration with civicrm
19 stars 46 forks source link

Action create sepa mandate failed. Caused by account_holder is required #667

Closed jojowork closed 4 months ago

jojowork commented 1 year ago

We updated CiviSepa to version 1.8 and got the following error message with formerly working formprocessor action: create recurring sepa mandate.

the error seems to be caused by this line: https://github.com/Project60/org.project60.sepa/blob/1.8.0/Civi/Sepa/ActionProvider/Action/CreateRecurringMandate.php#L52

The author seems to have unintendedly set the parameter to be required (and added a comment to later check what that flag means).

It also does not make a lot of sense to require an account holder field, because account holder is only an optional additional feature for the case that the account holder differs from the name of contact.

I will create an PR that sets the flag to false (not required).

jaapjansma commented 10 months ago

This issue still exists for the action for creating one-off mandates