search

Project60 / org.project60.sepa

SEPA direct debit integration with civicrm
19 stars 46 forks source link

#677 Adds new style token processing #693

Closed kainuk closed 8 months ago

kainuk commented 9 months ago

The same PR as, but rebased to the latest code base and implemented the suggestion of @bjendres

Here is the original description of @AlainBenbassat:

I noticed that the Most_Recent_SEPA_Mandate tokens are not replaced anymore in version 5.58.1, because the hooks hook_civicrm_tokens and hook_civicrm_tokenValues are deprecated.

This PR adds the new of processing tokens, while retaining the legacy way.

See also: https://docs.civicrm.org/dev/en/latest/framework/token/#defining-tokens for more information.

My attempt in this PR is to:

only touch the token code make new token processing and legacy processing as similar as possible convert array to [] in the files I changed move as much code out of sepa.php

kainuk commented 9 months ago

I have tested the PR on version 5.43. The old-skool triggers are needed for this version. I have also tested it on 5.65.1.

kainuk commented 9 months ago

The test fail, but the error does not come from a line of code in the extension, so I do not know how to prevent it.

bjendres commented 9 months ago

The test fail, but the error does not come from a line of code in the extension, so I do not know how to prevent it.

Yes, we need to fix the CircleCI config, see #694

kainuk commented 8 months ago

Hi @bjendres, I have another customer that needs this tokens, and would be helped with a merge.

bjendres commented 8 months ago

Hi @bjendres, I have another customer that needs this tokens, and would be helped with a merge.

I have now manually run the unit tests on this PR, and they passed.

I'll merge and release as 1.10-alpha1 1.10-alpha3

bjendres commented 8 months ago

I have merged it, please verify that it works with 1.10-alpha3: org.project60.sepa-1.10-alpha3.tar.gz