Fixed bug in the new token evaluation

Project60 / org.project60.sepa

SEPA direct debit integration with civicrm

19 stars 46 forks source link

Fixed bug in the new token evaluation #699

Closed kainuk closed 3 months ago

kainuk commented 4 months ago

The tokens still did not work in the new token system. (I missed this in the last test because on my system the old token replacement was also active and hid the bug).

Two fixes.

One misnomed variable.
Tokes replacement work better with an empty string.

bjendres commented 4 months ago

Looks good to me, thank you @kainuk

@jensschuppe any objections/concerns?

kainuk commented 3 months ago

Hi @bjendres or @jensschuppe, can this be merged. I have a customer needs this PR, but is in favour of installing the official source.

bjendres commented 3 months ago

Hi @bjendres or @jensschuppe, can this be merged. I have a customer needs this PR, but is in favour of installing the official source.

I have merged it and will tag an alpha version.

Just for the future: this would've been easier to review if you hadn't renamed $row to $tokenRow for some reason...

bjendres commented 3 months ago

Here you go, @kainuk: https://github.com/Project60/org.project60.sepa/releases/tag/1.10-alpha4

kainuk commented 3 months ago

Thanks @bjendres